integration: test lease revoke routine with JWT token #9773
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelegasse
reviewed
May 24, 2018
integration/v3_auth_test.go
Outdated
| testV3AuthWithLeaseRevokeWithRoot(t, true) | ||
| } | ||
|
|
||
| func testV3AuthWithLeaseRevokeWithRoot(t *testing.T, jwt bool) { |
There was a problem hiding this comment.
Rather than adding a flag here, perhaps it would be better to just pass in the ClusterConfig that should be used to run the test? If we find more edge cases in the future, it would be easier to add new configurations for the scenario.
etcd-io#9698 wasn't really testing the panic code path when leases are expiry. Signed-off-by: Gyuho Lee <gyuhox@gmail.com>
joelegasse
approved these changes
May 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#9698 wasn't really testing
the panic code path when leases are expiry.
ref. #9695